Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6013

Separate mount helpers for client and server

Details

    • Improvement
    • Resolution: Fixed
    • Minor
    • Lustre 2.8.0
    • Lustre 2.7.0, Lustre 2.5.3
    • None
    • 16757

    Description

      Currently a single mount helper, mount.lustre, is used to mount lustre on a client, as well as to start a lustre server (e.g. OST).

      This makes it harder to see bugs in which client-side mount code is executed in a server context or vice versa, and cause undesirable side-affects.

      An example seen at LLNL recently was with osd_init(). Client nodes could not mount a lustre filesystem because mount called osd_init(), which attempted to load the mount_osd_{zfs,ldiskfs} backfs modules. One of the modules failed to load, causing the mount to fail, even though the client does not use those modules at all.

      That specific bug is being corrected by change http://review.whamcloud.com/#/c/12550/ for LU-5851, but there may well be other similar issues that have not yet surfaced; and creating more is not difficult with the current code structure.

      The proposal here is to move server-side code from mount_lustre.c to mount_lustre_server.c, modify the build system to generate two separate binaries, mount.lustre and mount.lustre_server, and then update startup scripts, spec file, and documentation appropriately.

      Attachments

        Issue Links

          Activity

            [LU-6013] Separate mount helpers for client and server

            Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/41767
            Subject: LU-6013 lustre: make ldlm and target file lists
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 32be10f42fb1c998c2237d343e3d8e8cd6a9ea06

            gerrit Gerrit Updater added a comment - Neil Brown (neilb@suse.de) uploaded a new patch: https://review.whamcloud.com/41767 Subject: LU-6013 lustre: make ldlm and target file lists Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 32be10f42fb1c998c2237d343e3d8e8cd6a9ea06
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-12514 [ LU-12514 ]
            jgmitter Joseph Gmitter (Inactive) made changes -
            Fix Version/s New: Lustre 2.8.0 [ 11113 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]

            Landed for 2.8

            jgmitter Joseph Gmitter (Inactive) added a comment - Landed for 2.8

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13019/
            Subject: LU-6013 utils: don't initialize OSD code for client mount
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: ce85021cbb4b2e02a56321cfff8c03a50d9d4704

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/13019/ Subject: LU-6013 utils: don't initialize OSD code for client mount Project: fs/lustre-release Branch: master Current Patch Set: Commit: ce85021cbb4b2e02a56321cfff8c03a50d9d4704
            pjones Peter Jones made changes -
            Link Original: This issue is related to LDEV-14 [ LDEV-14 ]
            pjones Peter Jones made changes -
            Link New: This issue is related to LDEV-123 [ LDEV-123 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LDEV-14 [ LDEV-14 ]
            adilger Andreas Dilger made changes -
            Affects Version/s New: Lustre 2.5.3 [ 11100 ]
            Affects Version/s New: Lustre 2.7.0 [ 10631 ]

            I abandoned the master version of my osd_init() patch, but it probably still makes sense for b2_5 if Bruno's patch doesn't land there, to avoid problems mounting the client.

            adilger Andreas Dilger added a comment - I abandoned the master version of my osd_init() patch, but it probably still makes sense for b2_5 if Bruno's patch doesn't land there, to avoid problems mounting the client.

            People

              ofaaland Olaf Faaland
              ofaaland Olaf Faaland
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: