[LU-5864] New static analysis issues in lfs

• Type: Bug
• Resolution: Not a Bug
• Priority: Minor
• Fix Version/s: Lustre 2.7.0
• Affects Version/s: Lustre 2.7.0
• Labels: kw
• Severity: 3
• Assignee: Dmitry Eremin (Inactive)
• Reporter: Dmitry Eremin (Inactive)

Description

In commit 979203503af2f77d51bcf27375a1a09f5f28a4a3 (LU-4665 utils: lfs setstripe to specify OSTs) was introduced suspicious dereference of pointer 'ptr' before NULL check at line 704.

Issue Links

• is related to: LU-4629 Issues found by static analysis tools

Comments

[Dmitry Eremin (Inactive)]

ptr = strchrnul(arg, ',');
end_of_loop = *ptr == '\0';
*ptr = '\0';

According manual:

The strchrnul() function is like strchr() except that if c is not found in s, then it returns a pointer to the null byte at the end of s, rather than NULL.

Therefore ptr can not by NULL here. It's false positive of static analysis tool.