Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-3953 lustre build system improvments
  3. LU-5919

"make rpm" should build from the .src.rpm product of the "make srpm" target

Details

    • Technical task
    • Resolution: Fixed
    • Minor
    • Lustre 2.8.0
    • None
    • None
    • 16525

    Description

      The "make rpm" Make target should really use the .src.rpm file that is built under the "make srpm" Make target rather than building its own redundant .src.rpm.

      In addition to avoiding a bit of redundancy in the build system, building from the .src.rpm as part of the normal rpm build process would help to ensure that the .src.rpm file remains rebuildable (historically a recurring problem for the lustre build system).

      Attachments

        Issue Links

          Activity

            [LU-5919] "make rpm" should build from the .src.rpm product of the "make srpm" target
            pjones Peter Jones added a comment -

            Landed for 2.8

            pjones Peter Jones added a comment - Landed for 2.8

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12961/
            Subject: LU-5919 build: Make "make rpms" use "make srpm" output
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: a71ab04971382c77f708d6a082e8ee2fa845e9be

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/12961/ Subject: LU-5919 build: Make "make rpms" use "make srpm" output Project: fs/lustre-release Branch: master Current Patch Set: Commit: a71ab04971382c77f708d6a082e8ee2fa845e9be

            Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: http://review.whamcloud.com/12961
            Subject: LU-5919 build: Make "make rpms" use "make srpm" output
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: c57a03ddd5c1f580d86e3160774d5eb13b8cef46

            gerrit Gerrit Updater added a comment - Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: http://review.whamcloud.com/12961 Subject: LU-5919 build: Make "make rpms" use "make srpm" output Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: c57a03ddd5c1f580d86e3160774d5eb13b8cef46
            pjones Peter Jones added a comment -

            Dmitry

            Could you please review this patch and see how this could be applied to master?

            Thanks

            Peter

            pjones Peter Jones added a comment - Dmitry Could you please review this patch and see how this could be applied to master? Thanks Peter

            I pushed a copy of the patch that LLNL uses to accomplish this on out 2.5.3-llnl branch (see github.com/chaos/lustre):

            http://review.whamcloud.com/12712

            Granted this patch is based against b2_5. I probably won't have time to make a version for master until sometime after SC'14.

            morrone Christopher Morrone (Inactive) added a comment - I pushed a copy of the patch that LLNL uses to accomplish this on out 2.5.3-llnl branch (see github.com/chaos/lustre): http://review.whamcloud.com/12712 Granted this patch is based against b2_5. I probably won't have time to make a version for master until sometime after SC'14.

            People

              dmiter Dmitry Eremin (Inactive)
              morrone Christopher Morrone (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: