[LU-6221] Posix copytool --dry-run option flawed

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.8.0
• Environment: Any
• Severity: 3
• Assignee: Bruno Faccini (Inactive)
• Reporter: Bruno Faccini (Inactive)

Description

If the --dry-run option is used, the syntax checking allows --hsm-root to be omitted, which implies that the HSM root won't been dereferenced if doing a dry run. This does not appear to be the case.

In particular, the command:

$ lhsmtool_posix --max-sequence --dry-run /lustre

will segfault. Other instances look like they will have the same problem.

The check in ct_parseopts() that reads:

if (!opt.o_dry_run && opt.o_hsm_root == NULL)

should simply remove the "!opt.dry_run &&" clause. All valid operations require that the hsm root be specified.

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/13673/
Subject: LU-6221 utils: hsm_root is also required for --dry-run
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: adb39ea50c881a9f36d4a9fd2f8693eaec06b5d1

[Bruno Faccini (Inactive)]

Master patch is at http://review.whamcloud.com/13673.

[Gerrit Updater]

Faccini Bruno ([e-mail]) uploaded a new patch: http://review.whamcloud.com/13673
Subject: LU-6221 utils: hsm_root is also required for --dry-run
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5c9cba320168c96918e8e71d1c2f6d54439fb677