[LU-6460] LLIF_FILE_RESTORING is not cleared at end of restore

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.8.0
• Affects Version/s: Lustre 2.8.0
• Labels: hsm medium
• Severity: 3
• Assignee: Bruno Faccini (Inactive)
• Reporter: John Hammond

Description

The LLIF_FILE_RESTORING flag is not cleared until an IO is performed on the inode. This may cause stale file attributes to be cached if the file is stated during restore. To reproduce:

export MOUNT_2=y
llmount.sh
lctl conf_param lustre-MDT0000.mdt.hsm_control=enabled
mkdir -p /mnt/lustre-hsm
mount $HOSTNAME@tcp:/lustre /mnt/lustre-hsm -t lustre -o user_xattr,flock
mkdir -p /tmp/arc1
lhsmtool_posix -vvvv --hsm_root=/tmp/arc1 --daemon /mnt/lustre-hsm 2> /tmp/hsm.log
echo XXX > /mnt/lustre/f0
lfs hsm_archive /mnt/lustre/f0
sleep 1
lfs hsm_release /mnt/lustre/f0
killall lhsmtool_posix
cat /mnt/lustre/f0 &
sleep 1
stat /mnt/lustre2/f0
lhsmtool_posix -vvvv --hsm_root=/tmp/arc1 --daemon /mnt/lustre-hsm 2> /tmp/hsm.log
wait
dd if=/dev/zero of=/mnt/lustre/f0 count=1
stat /mnt/lustre/f0
stat /mnt/lustre2/f0
sleep 60
stat /mnt/lustre/f0
stat /mnt/lustre2/f0

Output

...
t:~# lhsmtool_posix -vvvv --hsm_root=/tmp/arc1 --daemon /mnt/lustre-hsm 2> /tmp/hsm.log
t:~# echo XXX > /mnt/lustre/f0
t:~# lfs hsm_archive /mnt/lustre/f0
t:~# sleep 1
t:~# lfs hsm_release /mnt/lustre/f0
t:~# killall lhsmtool_posix
t:~# cat /mnt/lustre/f0 &
[1] 10620
t:~# sleep 1
t:~# stat /mnt/lustre2/f0
  File: `/mnt/lustre2/f0'
  Size: 4         	Blocks: 1          IO Block: 4194304 regular file
Device: 2c54f966h/743766374d	Inode: 144115205255725063  Links: 1
Access: (0644/-rw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2015-04-13 16:58:17.000000000 -0500
Modify: 2015-04-13 16:58:17.000000000 -0500
Change: 2015-04-13 16:58:17.000000000 -0500
t:~# lhsmtool_posix -vvvv --hsm_root=/tmp/arc1 --daemon /mnt/lustre-hsm 2> /tmp/hsm.log
t:~# wait
XXX
[1]+  Done                    cat /mnt/lustre/f0
t:~# dd if=/dev/zero of=/mnt/lustre/f0 count=1
1+0 records in
1+0 records out
512 bytes (512 B) copied, 0.000714119 s, 717 kB/s
t:~# stat /mnt/lustre/f0
  File: `/mnt/lustre/f0'
  Size: 512       	Blocks: 8          IO Block: 4194304 regular file
Device: 2c54f966h/743766374d	Inode: 144115205255725063  Links: 1
Access: (0644/-rw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2015-04-13 16:58:17.000000000 -0500
Modify: 2015-04-13 16:58:28.000000000 -0500
Change: 2015-04-13 16:58:28.000000000 -0500
t:~# stat /mnt/lustre2/f0
  File: `/mnt/lustre2/f0'
  Size: 4         	Blocks: 1          IO Block: 4194304 regular file
Device: 2c54f966h/743766374d	Inode: 144115205255725063  Links: 1
Access: (0644/-rw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2015-04-13 16:58:17.000000000 -0500
Modify: 2015-04-13 16:58:28.000000000 -0500
Change: 2015-04-13 16:58:28.000000000 -0500
t:~# sleep 60
t:~# stat /mnt/lustre/f0
  File: `/mnt/lustre/f0'
  Size: 512       	Blocks: 8          IO Block: 4194304 regular file
Device: 2c54f966h/743766374d	Inode: 144115205255725063  Links: 1
Access: (0644/-rw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2015-04-13 16:58:17.000000000 -0500
Modify: 2015-04-13 16:58:28.000000000 -0500
Change: 2015-04-13 16:58:28.000000000 -0500
t:~# stat /mnt/lustre2/f0
  File: `/mnt/lustre2/f0'
  Size: 4         	Blocks: 1          IO Block: 4194304 regular file
Device: 2c54f966h/743766374d	Inode: 144115205255725063  Links: 1
Access: (0644/-rw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)
Access: 2015-04-13 16:58:17.000000000 -0500
Modify: 2015-04-13 16:58:28.000000000 -0500
Change: 2015-04-13 16:58:28.000000000 -0500

Issue Links

• is related to: LU-7040 Interop 2.7.0<->master sanity-hsm test_12q: wrong size after overwrite
• is related to: LU-4727 Lhsmtool_posix process stuck in ll_layout_refresh() when restoring

Comments

[Peter Jones]

Landed for 2.8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/14609/
Subject: LU-6460 llite: clear LLIF_FILE_RESTORING when done
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a2c4b0583a84165b867b18e1446c187d18335879

[Gerrit Updater]

Faccini Bruno ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14609
Subject: LU-6460 llite: clear LLIF_FILE_RESTORING when done
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 8a3f8dc28924784f3c06467c25a692779e65dfde

[John Hammond]

> John, what is the impact of this bug? What does userspace do with LLIF_FILE_RESTORING?

The impact is that the wrong size and attributes may be reported by stat. A reproducer is shown in the description.

Userspace cannot see LLIF_FILE_RESTORING. llite uses this flag to determine if the attributes from the MDT are sufficient for stat().

[Andreas Dilger]

John, what is the impact of this bug? What does userspace do with LLIF_FILE_RESTORING?

[Peter Jones]

Bruno

Could you please look into this one?

Peter