Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6496

Wrong code indentation in plain_authorize

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.8.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      The code in plain_authorize has misleading indentation hiding an assignment:

                      cfs_crypto_hash_digest(CFS_HASH_ALG_CRC32,
                              lustre_msg_buf(msg, PLAIN_PACK_MSG_OFF, 0),
                              lustre_msg_buflen(msg, PLAIN_PACK_MSG_OFF),
                              NULL, 0, (unsigned char *)&msg->lm_cksum, &hsize);
                              req->rq_reply_off = 0;
      

      Attachments

        Issue Links

          Activity

            [LU-6496] Wrong code indentation in plain_authorize
            pjones Peter Jones added a comment -

            Landed for 2.8

            pjones Peter Jones added a comment - Landed for 2.8

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/14591/
            Subject: LU-6496 ptlrpc: Fix wrong code indentation in plain_authorize
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: c56f7675bfb17b3847b38044153e86550ced3c8e

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/14591/ Subject: LU-6496 ptlrpc: Fix wrong code indentation in plain_authorize Project: fs/lustre-release Branch: master Current Patch Set: Commit: c56f7675bfb17b3847b38044153e86550ced3c8e

            Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/14591
            Subject: LU-6496 ptlrpc: Fix wrong code indentation in plain_authorize
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 908d1be5db42d79c37eae1afabada628f2c33628

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) uploaded a new patch: http://review.whamcloud.com/14591 Subject: LU-6496 ptlrpc: Fix wrong code indentation in plain_authorize Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 908d1be5db42d79c37eae1afabada628f2c33628

            People

              wc-triage WC Triage
              green Oleg Drokin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: