[LU-6506] Always false comparison in osc_init_grant

• Type: Bug
• Resolution: Unresolved
• Priority: Minor
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

With patch from Dmitry (hash eb2e1b63, LU-5417) we not have a piece of a dead code in osc_init_grant, so we need somebody to take a look and decide if something important was lost or if we can kill it.

        if (cli->cl_avail_grant < 0) {
                CWARN("%s: available grant < 0: avail/ocd/dirty %ld/%u/%ld\n",
                      cli->cl_import->imp_obd->obd_name, cli->cl_avail_grant,
                      ocd->ocd_grant, cli->cl_dirty_pages << PAGE_CACHE_SHIFT);
                /* workaround for servers which do not have the patch from
                 * LU-2679 */
                cli->cl_avail_grant = ocd->ocd_grant;
        }

Note that cl_avail_grant is now unsigned, so could never be < 0.

Issue Links

• is related to: LU-5417 lod_load_striping_locked() fails to detect errors from lod_get_lmv_ea()