Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6508

llog_test.c::llog_test_8 unnecessary use of rc2

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
    • Severity:
      3
    • Rank (Obsolete):
      9223372036854775807

      Description

      It looks like there are a couple of spots in llog_test_8 that use rc2 redundantly sine rc would always be 0 in those cases:

      /home/green/smt/git/lustre-release/lustre/obdclass/llog_test.c:995 llog_test_8() warn: we tested 'rc' before and it was 'false'
      /home/green/smt/git/lustre-release/lustre/obdclass/llog_test.c:1026 llog_test_8() warn: we tested 'rc' before and it was 'false'
      

      I feel like if we take them out and replace with just plain rc assignment, the code would become a tiny bit more readable.

        Attachments

          Activity

            People

            • Assignee:
              wc-triage WC Triage
              Reporter:
              green Oleg Drokin
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: