[LU-6510] mdt_handle_idmap unsafe access to req->rq_export

• Type: Bug
• Resolution: Duplicate
• Priority: Minor
• Labels: easy hackathon2017
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

smatch highlighted this unsafe usage:

int mdt_handle_idmap(struct tgt_session_info *tsi)
{
        struct ptlrpc_request   *req = tgt_ses_req(tsi);
        struct mdt_device       *mdt = mdt_exp2dev(req->rq_export);
        struct mdt_export_data *med;
        struct ptlrpc_user_desc *pud = req->rq_user_desc;
        struct md_identity *identity;
        __u32 opc;
        int rc = 0;
        ENTRY;

        if (!req->rq_export)
                RETURN(0);

Probably need to move the mdt variable assignment to after this check.

Issue Links

• duplicates: LU-6971 Remove obsolete remote client and "lfs cp|ls|getacl|setacl" commands