[LU-6517] lmv_disconnect_mdc dereferences a potential NULL pointer

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.8.0
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

smatch found this piece in lmv_disconnect_mdc:

        if (mdc_obd) {
                mdc_obd->obd_force = obd->obd_force;
                mdc_obd->obd_fail = obd->obd_fail;
                mdc_obd->obd_no_recov = obd->obd_no_recov;
        }

        if (lmv->targets_proc_entry != NULL)
                lprocfs_remove_proc_entry(mdc_obd->obd_name,
                                          lmv->targets_proc_entry);

Comments

[Peter Jones]

Landed for 2.8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/14605/
Subject: LU-6517 lmv: fix potential null pointer dereference
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 47c49d3cbb21c94c03831bb4d524d53772a1c2f9

[Oleg Drokin]

Or should we do it unconditionally and instead of getting the name from mdc_obd scrub the name from proc entry instead somehow?

[Gerrit Updater]

Oleg Drokin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14605
Subject: LU-6517 lmv: fix potential null pointer dereference
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d09a83b72c96d08787b96308b6f463aba9d82441