[LU-6540] too many arguments in a format string in lustre tests, lustre/tests/flock.c

• Type: Bug
• Resolution: Fixed
• Priority: Trivial
• Fix Version/s: Lustre 2.8.0
• Environment: Ubuntu 15.04, cppcheck static anaysis + GCC 4.9.2
• Severity: 3
• Assignee: Dmitry Eremin (Inactive)
• Reporter: Colin Ian King

Description

Static analysis with cppcheck found the following issue in lustre/tests/flock.c:

Checking lustre/tests/flock.c...
[lustre/tests/flock.c:178]: (warning) printf format string requires 0 parameters but 1 is given.

fd = open(file, O_RDWR|O_CREAT, (mode_t)0666);
if (fd < 0)

{ printf("error open file: %m\n", file); exit(-1); }

The %m prints strerror(errno), but there is no %s specifier for the file. I believe a modern version GCC will flag this with a warning too.

Comments

[Peter Jones]

Landed for 2.8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/14815/
Subject: LU-6540 test: fix no %s specifier for the file
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fb36d989168ea1794c8c0abb387982f857ed647f

[Gerrit Updater]

Dmitry Eremin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/14815
Subject: LU-6540 test: fix no %s specifier for the file
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 9de143f62ab1991ff5f9ff70dfafaf1728cc1af7