Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6710

conf-sanity test 82a fails with ‘/usr/bin/lfs setstripe -o 22456,27728,65534 -i 65534 /mnt/lustre/d82a.conf-sanity/f82a.conf-sanity-3 failed‘

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.8.0
    • Lustre 2.8.0
    • None
    • 3
    • 9223372036854775807

    Description

      conf-sanity test_82a fails on review-dne-part-1 with ‘/usr/bin/lfs setstripe -o 22456,27728,65534 -i 65534 /mnt/lustre/d82a.conf-sanity/f82a.conf-sanity-3 failed‘

      From the test log:

      /usr/bin/lfs setstripe -o 22456,27728,65534 -i 65534 /mnt/lustre/d82a.conf-sanity/f82a.conf-sanity-3
      error: bad stripe offset 65534: Invalid argument (22)
      error: setstripe: create stripe file '/mnt/lustre/d82a.conf-sanity/f82a.conf-sanity-3' failed
       conf-sanity test_82a: @@@@@@ FAIL: /usr/bin/lfs setstripe -o 22456,27728,65534 -i 65534 /mnt/lustre/d82a.conf-sanity/f82a.conf-sanity-3 failed 
      

      Could the index just be too large for input to '-i' the start OST index?

      Test failure at https://testing.hpdd.intel.com/test_sets/da5f5fbe-1010-11e5-a2d3-5254006e85c2

      Attachments

        Issue Links

          Activity

            [LU-6710] conf-sanity test 82a fails with ‘/usr/bin/lfs setstripe -o 22456,27728,65534 -i 65534 /mnt/lustre/d82a.conf-sanity/f82a.conf-sanity-3 failed‘

            Another instance found for interop : 2.7.1 Server/EL6.7 Client
            Server: 2.7.1, b2_7_fe/34
            Client: master, build# 3303, RHEL 6.7
            https://testing.hpdd.intel.com/test_sets/148c9d60-bb05-11e5-9137-5254006e85c2

            Tests ran on 01/13/2016.

            standan Saurabh Tandan (Inactive) added a comment - - edited Another instance found for interop : 2.7.1 Server/EL6.7 Client Server: 2.7.1, b2_7_fe/34 Client: master, build# 3303, RHEL 6.7 https://testing.hpdd.intel.com/test_sets/148c9d60-bb05-11e5-9137-5254006e85c2 Tests ran on 01/13/2016.

            Patch landed to master.

            jamesanunez James Nunez (Inactive) added a comment - Patch landed to master.

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15824/
            Subject: LU-6710 tests: Constrain stripe index conf-sanity test 82a
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: c919cdf5d960da9f3b78fd2c04b7e09ef915d3c6

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15824/ Subject: LU-6710 tests: Constrain stripe index conf-sanity test 82a Project: fs/lustre-release Branch: master Current Patch Set: Commit: c919cdf5d960da9f3b78fd2c04b7e09ef915d3c6

            James Nunez (james.a.nunez@intel.com) uploaded a new patch: http://review.whamcloud.com/15824
            Subject: LU-6710 tests: Constrain stripe index conf-sanity test 82a
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 82c93241b517d094857ec6f80cfa0e35ffddcc62

            gerrit Gerrit Updater added a comment - James Nunez (james.a.nunez@intel.com) uploaded a new patch: http://review.whamcloud.com/15824 Subject: LU-6710 tests: Constrain stripe index conf-sanity test 82a Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 82c93241b517d094857ec6f80cfa0e35ffddcc62

            The maximum OST index is:

            #define LOV_V1_INSANE_STRIPE_COUNT 65532 /* maximum stripe count bz13933 */
            
            static inline bool llapi_stripe_index_is_valid(int64_t index)
            { 
                    return index >= -1 && index <= LOV_V1_INSANE_STRIPE_COUNT;
            }
            
            /* Compatibility macro for legacy llapi functions that use "offset"
             * terminology instead of the preferred "index". */
            #define llapi_stripe_offset_is_valid(os) llapi_stripe_index_is_valid(os)
            
            int llapi_stripe_limit_check(unsigned long long stripe_size, int stripe_offset,
                                            int stripe_count, int stripe_pattern)
            {
                    :
                    :
                    if (!llapi_stripe_offset_is_valid(stripe_offset)) {
                            rc = -EINVAL;
                            llapi_error(LLAPI_MSG_ERROR, rc, "error: bad stripe offset %d",
                                            stripe_offset);
                            return rc;
                    }
                    :
                    :
            }
            

            So we need to limit the OST index to be 65532 or less, like index=$(((RANDOM - 1) * 2)).

            While you are in there please change the one use of llapi_stripe_offset_is_valid() to llapi_stripe_index_is_valid() so at least our own code is not using the deprecated version of the function.

            adilger Andreas Dilger added a comment - The maximum OST index is: #define LOV_V1_INSANE_STRIPE_COUNT 65532 /* maximum stripe count bz13933 */ static inline bool llapi_stripe_index_is_valid(int64_t index) { return index >= -1 && index <= LOV_V1_INSANE_STRIPE_COUNT; } /* Compatibility macro for legacy llapi functions that use "offset" * terminology instead of the preferred "index". */ #define llapi_stripe_offset_is_valid(os) llapi_stripe_index_is_valid(os) int llapi_stripe_limit_check(unsigned long long stripe_size, int stripe_offset, int stripe_count, int stripe_pattern) { : : if (!llapi_stripe_offset_is_valid(stripe_offset)) { rc = -EINVAL; llapi_error(LLAPI_MSG_ERROR, rc, "error: bad stripe offset %d", stripe_offset); return rc; } : : } So we need to limit the OST index to be 65532 or less, like index=$(((RANDOM - 1) * 2)) . While you are in there please change the one use of llapi_stripe_offset_is_valid() to llapi_stripe_index_is_valid() so at least our own code is not using the deprecated version of the function.

            People

              jamesanunez James Nunez (Inactive)
              jamesanunez James Nunez (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: