[LU-6746] move IT_* definitions to lustre_idl.h

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.8.0
• Affects Version/s: Lustre 2.8.0
• Severity: 3
• Assignee: Dmitry Eremin (Inactive)
• Reporter: Andreas Dilger

Description

The IT_* definitions (e.g. IT_OPEN, IT_CREAT, etc) in include/obd.h are actually packed into ldlm_intent on the wire and are part of the network protocol (despite the incorrect comment there that they need to match with include/linux/namei.h.

These values should be moved (without changing the values!) into lustre_idl.h as a named enum with explicit 0x000n style assignments (see e.g. enum lfsck_event_flags, and then struct lookup_intent->it_op should be changed to use that enum. They also need to be explicitly checked in wirecheck.c and then wiretest.c should be regenerated using "make -c lustre/utils newwiretest" and the resulting files verified that they only add the new fields with the correct values.

Issue Links

• is related to: LU-6215 Sync Lustre external tree with lustre linux kernel client
• is related to: LU-6401 Untangle lustre userland and kernel headers

Comments

[Joseph Gmitter (Inactive)]

Landed for 2.8.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/16228/
Subject: LU-6746 ptlrpc: Move IT_* definitions to lustre_idl.h
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9ea40a338c6e58a59792df56f963e58afced4e26

[Gerrit Updater]

Ben Evans ([e-mail]) uploaded a new patch: http://review.whamcloud.com/16228
Subject: LU-6746 ptlrpc: Move IT_* definitions to lustre_idl.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f27fce9292b95c889352c0ca9414d6a23bc14c9f

[Andreas Dilger]

This should also be fixed in the upstream kernel.