Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6840

update memory reply data in DNE update replay

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • Lustre 2.8.0
    • Lustre 2.8.0
    • None
    • 3
    • 9223372036854775807

    Description

      DNE update replay might update last_rcvd file, but because it will be operated on OSD/OSP directly, so the memory structure (ted/lrd etc) will not be updated by update replay handler, so it needs update these memory structure by itself after each update replay. (see replay_request_or_update() ).

      In current implementation, this is done in target_update_lcd(), but multiple slot patch just changed this process, so target_update_lcd needs to be fixed as well.

      Attachments

        Issue Links

          Activity

            [LU-6840] update memory reply data in DNE update replay

            Landed for 2.8.

            jgmitter Joseph Gmitter (Inactive) added a comment - Landed for 2.8.

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15576/
            Subject: LU-6840 target: update reply data after update replay
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 9543df37cdfd35980c888440265d161e350d166d

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15576/ Subject: LU-6840 target: update reply data after update replay Project: fs/lustre-release Branch: master Current Patch Set: Commit: 9543df37cdfd35980c888440265d161e350d166d
            di.wang Di Wang added a comment -

            For cross-MDT operation, the updates (including update last_rcvd and reply_data) will be recorded on all of MDTs. So during the recovery, once the updates on the master MDT are missing, then these updates needs to be redo on the master MDT, which means these last_rcvd and reply_data file needs to be updated as well in this process, and those memory stuff (lcd etc) needs to be updated as well, which is normally through the trans stop callback.

            In current implementation, due to the speciality of the DNE recovery and recent changes of multiple slot, stop callback can not be called correctly, which is this patch trying to resolve.

            di.wang Di Wang added a comment - For cross-MDT operation, the updates (including update last_rcvd and reply_data) will be recorded on all of MDTs. So during the recovery, once the updates on the master MDT are missing, then these updates needs to be redo on the master MDT, which means these last_rcvd and reply_data file needs to be updated as well in this process, and those memory stuff (lcd etc) needs to be updated as well, which is normally through the trans stop callback. In current implementation, due to the speciality of the DNE recovery and recent changes of multiple slot, stop callback can not be called correctly, which is this patch trying to resolve.

            I am not sure to understand the context, but the metadata operations operated on OSD/OSP should not make use of the multiple slot patch.

            At the moment (lustre 2.8) multiple slot feature is only supported for MDT exports that have the OBD_CONNECT_MULTIMODRPCS flag, that is to say exports for MDC. This flag should not be set on exports for OSP.

            pichong Gregoire Pichon added a comment - I am not sure to understand the context, but the metadata operations operated on OSD/OSP should not make use of the multiple slot patch. At the moment (lustre 2.8) multiple slot feature is only supported for MDT exports that have the OBD_CONNECT_MULTIMODRPCS flag, that is to say exports for MDC. This flag should not be set on exports for OSP.

            wangdi (di.wang@intel.com) uploaded a new patch: http://review.whamcloud.com/15576
            Subject: LU-6840 target: update reply data after update replay
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 49d65b184daf7c6d580f918b3befd41a16c1f278

            gerrit Gerrit Updater added a comment - wangdi (di.wang@intel.com) uploaded a new patch: http://review.whamcloud.com/15576 Subject: LU-6840 target: update reply data after update replay Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 49d65b184daf7c6d580f918b3befd41a16c1f278

            People

              di.wang Di Wang
              di.wang Di Wang
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: