[LU-6891] fix grow_xattr() defect

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.8.0
• Affects Version/s: Lustre 2.7.0

Epic/Theme

patch test

• Severity: 3
• Assignee: WC Triage
• Reporter: Elena Gryaznova

Description

grow_xattr() {
...
   [ -z $(lctl get_param -n mdc.*.connect_flags | grep xattr) ] &&
         skip "must have user_xattr" && return 0
..
}

string needs to be quoted to avoid syntax error on DNE setup:
mdscount=2 :

# lctl get_param  mdc.*.connect_flags | grep xattr
xattr
xattr
# find /proc/fs/lustre/ -name connect_flags | grep mdc
/proc/fs/lustre/mdc/lustre-MDT0001-mdc-ffff88005a998000/connect_flags
/proc/fs/lustre/mdc/lustre-MDT0000-mdc-ffff88005a998000/connect_flags

xtrace:

+ grow_xattr 65536
+ local xsize=65536
+ local file=/mnt/lustre/f102ha.sanity
++ grep xattr
++ lctl get_param -n 'mdc.*.connect_flags'
+ '[' -z xattr xattr ']'
sanity.sh: line 6447: [: xattr: binary operator expected

mdscount=3 :

++ lctl get_param -n 'mdc.*.connect_flags'
+ '[' -z xattr xattr xattr ']'
sanity.sh: line 6447: [: too many arguments

Comments

[Peter Jones]

Landed for 2.8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/15672/
Subject: LU-6891 test: fix grow_xattr() defect
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 683b4b29540bf100725adf9b9b4412b6324734e9

[Gerrit Updater]

Elena Gryaznova ([e-mail]) uploaded a new patch: http://review.whamcloud.com/15672
Subject: LU-6891 test: fix grow_xattr() defect
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1b0efdb3fd02978741e77e30adcdf1f2404a3e26