Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6929

typo in cfs_hash_for_each_relax()

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • Lustre 2.8.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      This is introduced in: fe60e0135ee2334440247cde167b707b223cf11d

      +       if (start > 0 && rc != 0) {
+               end = start;
+               start = 0;
+               goto again;
+       }

      I think it should be "if (start > 0 && rc == 0)", rc != 0 means caller want break the iteration.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-6529 Server side lock limits to avoid unnecessary memory exhaustion

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            [LU-6929] typo in cfs_hash_for_each_relax()
            mdiep Minh Diep made changes -
            Link New: This issue is related to JFC-20 [ JFC-20 ]
            mdiep Minh Diep made changes -
            Link Original: This issue is related to JFC-17 [ JFC-17 ]
            pjones Peter Jones made changes -
            Link New: This issue is related to LDEV-301 [ LDEV-301 ]
            pjones Peter Jones made changes -
            Link New: This issue is related to JFC-17 [ JFC-17 ]
            pjones Peter Jones made changes -
            Link Original: This issue is related to SEA-336 [ SEA-336 ]
            pjones Peter Jones made changes -
            Link New: This issue is duplicated by SEA-336 [ SEA-336 ]
            vinayakh Vinayak (Inactive) made changes -
            Link New: This issue is related to SEA-336 [ SEA-336 ]
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.8.0 [ 11113 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            pjones Peter Jones added a comment -

            Landed for 2.8

            pjones Peter Jones added a comment - Landed for 2.8
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15813/
            Subject: LU-6929 libcfs: typo in cfs_hash_for_each_relax()
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: dcf045eb782a0660abf092796f3c316dc72721b8

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15813/ Subject: LU-6929 libcfs: typo in cfs_hash_for_each_relax() Project: fs/lustre-release Branch: master Current Patch Set: Commit: dcf045eb782a0660abf092796f3c316dc72721b8

            People

              niu Niu Yawei (Inactive)
              niu Niu Yawei (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: