[LU-6938] zfs osd_xattr_list forgets to unlock a semaphore

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.8.0
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

It looks like we are forgetting an unlock in lustre/osd-zfs/osd_xattr.c::osd_xattr_list

        down(&obj->oo_guard);

        rc = osd_sa_xattr_list(env, obj, lb);
        if (rc < 0)
                GOTO(out, rc);
...
                if (lb->lb_buf != NULL) {
                        if (counted + rc + 1 > lb->lb_len)
                                RETURN(-ERANGE);
...
out:
        up(&obj->oo_guard);
        RETURN(rc);