Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-6947

Stray comment in ptlrpc_start_pinger

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Trivial
    • Lustre 2.8.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      There's this comment in ptlrpc_start_pinger:

              /* CLONE_VM and CLONE_FILES just avoid a needless copy, because we
               * just drop the VM and FILES in kthread_run() right away. */
              task = kthread_run(ptlrpc_pinger_main, &pinger_thread,
                                 pinger_thread.t_name);
      

      This does not make any sense anymore. Back when this was cfs_daemonize call, we did pass process flags there, but commit c8fd9c3c converted everything to kthread_ru that does not take any flags and so now this coment is totally out of place.

      A patch to remove it will be submitted shortly

      Attachments

        Activity

          People

            green Oleg Drokin
            green Oleg Drokin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: