Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-7027

Suspicios dereference in class_config_llog_handler

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.9.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      In the class_config_llog_handler there's this code:

                      if (clli->cfg_flags & CFG_F_EXCLUDE) {
                              CDEBUG(D_CONFIG, "cmd: %x marked EXCLUDED\n",
                                     lcfg->lcfg_command);
                              if (lcfg->lcfg_command == LCFG_LOV_ADD_OBD)
                                      /* Add inactive instead */
                                      lcfg->lcfg_command = LCFG_LOV_ADD_INA;
                      }
      
                      lustre_cfg_bufs_init(&bufs, lcfg);
      
                      if (clli && clli->cfg_instance &&
                          LUSTRE_CFG_BUFLEN(lcfg, 0) > 0){
      ...
      

      So we dereference clli and then see if it was NULL? Does not sound right.

      The upper part of code was added by Nathaniel in http://review.whamcloud.com/6197

      Attachments

        Activity

          People

            utopiabound Nathaniel Clark
            green Oleg Drokin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: