Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-7077

Pointer 'hash' returned from call to function 'cfs_hash_getref' may be NULL and will be dereferenced.

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.8.0
    • None
    • 3
    • 9223372036854775807

    Description

      lustre/obdclass/genops.c:944

      hash = cfs_hash_getref(exp->exp_obd->obd_gen_hash);
cfs_hash_del(hash, &ted->ted_lcd->lcd_generation,
	     &exp->exp_gen_hash);
cfs_hash_putref(hash);

      struct cfs_hash *cfs_hash_getref(struct cfs_hash *hs)
{
	if (atomic_inc_not_zero(&hs->hs_refcount))
		return hs;
	return NULL;
}

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-6840 update memory reply data in DNE update replay

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved

          Activity

            [LU-7077] Pointer 'hash' returned from call to function 'cfs_hash_getref' may be NULL and will be dereferenced.
            jgmitter Joseph Gmitter (Inactive) made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            pjones Peter Jones made changes -
            Link New: This issue is related to JFC-14 [ JFC-14 ]
            pjones Peter Jones made changes -
            Assignee Original: Di Wang [ di.wang ] New: Bob Glossman [ bogl ]
            pjones Peter Jones made changes -
            Assignee Original: WC Triage [ wc-triage ] New: Di Wang [ di.wang ]
            pjones Peter Jones made changes -
            Fix Version/s New: Lustre 2.8.0 [ 11113 ]
            pjones Peter Jones made changes -
            Link New: This issue is related to LU-6840 [ LU-6840 ]
            dmiter Dmitry Eremin (Inactive) made changes -
            Description Original: lustre/obdclass/genops.c:944
            {code}
            hash = cfs_hash_getref(exp->exp_obd->obd_gen_hash);
            cfs_hash_del(hash, &ted->ted_lcd->lcd_generation,
            &exp->exp_gen_hash);
            cfs_hash_putref(hash);
            {code}

            {code}
            struct cfs_hash *cfs_hash_getref(struct cfs_hash *hs)
            {
            if (atomic_inc_not_zero(&hs->hs_refcount))
            return hs;
            return NULL;
            }
            {code}             		New: lustre/obdclass/genops.c:944
            {code}
            hash = cfs_hash_getref(exp->exp_obd->obd_gen_hash);
            cfs_hash_del(hash, &ted->ted_lcd->lcd_generation,
            &exp->exp_gen_hash);
            cfs_hash_putref(hash);
            {code}

            {code}
            struct cfs_hash *cfs_hash_getref(struct cfs_hash *hs)
            {
            if (atomic_inc_not_zero(&hs->hs_refcount))
            return hs;
            return NULL;
            }
            {code}
            dmiter Dmitry Eremin (Inactive) created issue -

            People

              bogl Bob Glossman (Inactive)
              dmiter Dmitry Eremin (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: