[LU-7111] misleading error message in mgs_write_log_param

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Affects Version/s: Lustre 2.8.0
• Severity: 3
• Assignee: Nathaniel Clark
• Reporter: parinay v kondekar (Inactive)

Description

I mistakenly added a wrong parameter to MDS "mds.quota_type=ug" but tunefs.lustre didn't complain about it.

Later when I mount the MDS target, the operation failed with ENOSYS. The log says:

Nov 4 11:08:57 cshao kernel: Lustre: MGC10.76.101.91@tcp: Reactivating import
Nov 4 11:08:57 cshao kernel: Lustre: Found index 0 for lustre-MDT0000, updating log
Nov 4 11:08:57 cshao kernel: Lustre: Ignoring unrecognized param 'mds.quota_type=ug'
Nov 4 11:08:57 cshao kernel: LustreError: 21069:0:(mgs_handler.c:539:mgs_handle_target_reg()) Failed to write lustre-MDT0000 log (-38)
Nov 4 11:08:57 cshao kernel: LustreError: 21043:0:(obd_mount.c:1163:server_start_targets()) Required registration failed for lustre-MDT0000: -38
Nov 4 11:08:57 cshao kernel: LustreError: 21043:0:(obd_mount.c:1739:server_fill_super()) Unable to start targets: -38

Apparently it does not ignore the wrong parameter. Instead it failed the mount totally.

So we either fix the misleading message or we should ignore ENOSYS by converting it to EOK and return to the caller.

Comments

[Peter Jones]

Landed for 2.9

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/21112/
Subject: LU-7111 revert: b=22386 disallow wrong conf_param options
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 70d044e5b5947c885b084dd350fff62666b4b702

[Nathaniel Clark]

Patch to revert change that introduced mount failure for unrecognized params:
http://review.whamcloud.com/21112

[Nathaniel Clark]

Patch http://review.whamcloud.com/16292 is Abandoned

[Gerrit Updater]

Parinay Kondekar ([e-mail]) uploaded a new patch: http://review.whamcloud.com/16292
Subject: LU-7111 misleading error message in mgs_write_log_param
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 0b75bb70164f67688e7ca1e7cec6ee5f4ff5491b