Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-724

CLIO does not set lock handle in BRW

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Fix
    • Minor
    • None
    • Lustre 2.1.0
    • None
    • 3
    • 10478

    Description

      Unlike b1_8, CLIO does not set a valid lock handle in bulk write requests. osc_build_req() still uses oap->oap_ldlm_lock to fill the lock handle, but oap_ldlm_lock is always NULL, so we end up with oa->o_handle = NULL in requests.

      We have been discussing for a while that all - when relevant of course - requests should specify a lock handle, so this is really a regression from this regard.
      This lock handle is also used on the OST side to determine whether or not a BRW should make processed as a HP request. Not providing a lock handle put more load on the OST (e.g. in ost_rw_hpreq_check->ost_rw_prolong_locks()) since we always have to iterate over the list of dlm locks.

      Attachments

        Activity

          People

            jay Jinshan Xiong (Inactive)
            johann Johann Lombardi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: