Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-725

dead code in ll_direct_rw_pages()

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • None
    • Lustre 2.1.0
    • None
    • 3
    • 10406

      ssize_t ll_direct_rw_pages(const struct lu_env *env, struct cl_io *io,
                                 int rw, struct inode *inode,
                                 struct ll_dio_pages *pv)
      {
              ...
              for (i = 0; i < page_count; i++) {
                      ...
                      clp = cl_page_find(env, obj, cl_index(obj, file_offset),
                                         pv->ldp_pages[i], CPT_TRANSIENT);
                      ...
                      rc = cl_page_own(env, io, clp);
                      ...
                      /* check the page type: if the page is a host page, then do
                       * write directly */
                      if (clp->cp_type == CPT_CACHEABLE) {
      ------------------------> since transient pages are not stored in the radix tree
                                any more, all the code under this if statement is now useless.
      

            jay Jinshan Xiong (Inactive)
            johann Johann Lombardi (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: