Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-7318

OUT: dynamic reply buffer

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • Lustre 2.8.0
    • Lustre 2.8.0
    • None
    • 9223372036854775807

    Description

      osp_prep_update_req() allocates 4K as a reply buffer where 4K is hardcoded. instead buffer size should depend on the number of update in the request. similarly, the target should check whether reply buffer is big enough to store all the results.

      Attachments

        Issue Links

          is blocking

          Improvement - An improvement or enhancement to an existing feature or task. LU-4215 Some expected improvements for OUT

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-6831 The ticket for tracking all DNE2 bugs

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Reopened

          Activity

            [LU-7318] OUT: dynamic reply buffer
            jgmitter Joseph Gmitter (Inactive) added a comment -

            Landed for 2.8

            jgmitter Joseph Gmitter (Inactive) added a comment - Landed for 2.8
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/16889/
            Subject: LU-7318 out: dynamic reply size
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 12d6356a48de70922975e38451059211c753252e

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/16889/ Subject: LU-7318 out: dynamic reply size Project: fs/lustre-release Branch: master Current Patch Set: Commit: 12d6356a48de70922975e38451059211c753252e
            jhammond John Hammond added a comment -

            Di,

            Why wasn't the stupid test disabled 4+ weeks ago?

            jhammond John Hammond added a comment - Di, Why wasn't the stupid test disabled 4+ weeks ago?
            simmonsja James A Simmons added a comment -

            Agree. I also have seen sanity test 300k take out my nodes.

            simmonsja James A Simmons added a comment - Agree. I also have seen sanity test 300k take out my nodes.
            di.wang Di Wang added a comment -

            Actually, after we change OUT_UPDATE_REPLY_SIZE from 16384 to 4096 ( http://review.whamcloud.com/15899), this problem already bite us, because 4096 is certainly not enough for some big updates operation like sanity.sh 300k "test large striped directory". Simply run "MDSCOUNT=4 ONLY=300 sh sanity.sh" 2/3 times, will cause memory corruption. So this patch needs to get into 2.8.

            di.wang Di Wang added a comment - Actually, after we change OUT_UPDATE_REPLY_SIZE from 16384 to 4096 ( http://review.whamcloud.com/15899 ), this problem already bite us, because 4096 is certainly not enough for some big updates operation like sanity.sh 300k "test large striped directory". Simply run "MDSCOUNT=4 ONLY=300 sh sanity.sh" 2/3 times, will cause memory corruption. So this patch needs to get into 2.8.
            gerrit Gerrit Updater added a comment -

            Alex Zhuravlev (alexey.zhuravlev@intel.com) uploaded a new patch: http://review.whamcloud.com/16889
            Subject: LU-7318 out: dynamic reply size
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: bbcb85b359b982271abd509a79feec7c42b3d987

            gerrit Gerrit Updater added a comment - Alex Zhuravlev (alexey.zhuravlev@intel.com) uploaded a new patch: http://review.whamcloud.com/16889 Subject: LU-7318 out: dynamic reply size Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: bbcb85b359b982271abd509a79feec7c42b3d987

            People

              bzzz Alex Zhuravlev
              bzzz Alex Zhuravlev
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: