[LU-7396] lfs migrate handler oopses on bad MDT indexes

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.8.0
• Affects Version/s: Lustre 2.8.0
• Severity: 3
• Assignee: Di Wang
• Reporter: John Hammond

Description

This is likely because in ll_migrate() we do not handle failures from md_rename() properly.

# export MDSCOUNT=4
# llmount.sh
...
# cd /mnt/lustre
# mkdir d0
# lfs migrate -m 42 d0

[ 7176.545415] BUG: unable to handle kernel NULL pointer dereference at 0000000000000328
[ 7176.546390] IP: [<ffffffffa0cc9fe8>] __req_capsule_get+0x48/0x6f0 [ptlrpc]
[ 7176.546390] PGD abe39067 PUD ab548067 PMD 0 
[ 7176.546390] Oops: 0000 [#1] SMP 
...
[ 7176.546390] Process lfs (pid: 5703, threadinfo ffff8800ab54c000, task ffff8800ab4e81c0)
[ 7176.546390] Stack:
[ 7176.546390]  ffff8800ab54db58 ffffffff810b74bd ffff8800ab54dba8 0000000000000282
[ 7176.546390] <d> ffff8800ab54dba8 ffffffffa0f74821 0000000000000000 ffff8800ad394330
[ 7176.546390] <d> 0000000000000320 ffff8800b2460a78 ffff8800ab449ca8 ffff8800b23ed138
[ 7176.546390] Call Trace:
[ 7176.546390]  [<ffffffff810b74bd>] ? trace_hardirqs_on+0xd/0x10
[ 7176.546390]  [<ffffffffa0f74821>] ? lmv_getattr+0x121/0x560 [lmv]
[ 7176.546390]  [<ffffffffa0cca798>] req_capsule_server_get+0x18/0x20 [ptlrpc]
[ 7176.546390]  [<ffffffffa1501010>] ll_migrate+0x350/0x11f0 [lustre]
[ 7176.546390]  [<ffffffffa14ededa>] ll_dir_ioctl+0x5f4a/0x6460 [lustre]
[ 7176.546390]  [<ffffffff8115eb20>] ? handle_pte_fault+0x90/0xa50
[ 7176.546390]  [<ffffffffa14e39b0>] ? ll_dir_open+0x0/0xf0 [lustre]
[ 7176.546390]  [<ffffffffa14e39b0>] ? ll_dir_open+0x0/0xf0 [lustre]
[ 7176.546390]  [<ffffffff8115f70a>] ? handle_mm_fault+0x22a/0x300
[ 7176.546390]  [<ffffffff810a4523>] ? up_read+0x23/0x40
[ 7176.546390]  [<ffffffff8104bc84>] ? __do_page_fault+0x244/0x4b0
[ 7176.546390]  [<ffffffff811b8902>] vfs_ioctl+0x22/0xa0
[ 7176.546390]  [<ffffffff810b74bd>] ? trace_hardirqs_on+0xd/0x10
[ 7176.546390]  [<ffffffff811b8aa4>] do_vfs_ioctl+0x84/0x590
[ 7176.546390]  [<ffffffff811b9031>] sys_ioctl+0x81/0xa0
[ 7176.546390]  [<ffffffff8100b072>] system_call_fastpath+0x16/0x1b

Comments

[Joseph Gmitter (Inactive)]

Landed for 2.8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/17079/
Subject: LU-7396 llite: check request != NULL in ll_migrate
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 544d46eb8f13b9ba9f33d0af796665c11ea45163

[Gerrit Updater]

wangdi ([e-mail]) uploaded a new patch: http://review.whamcloud.com/17079
Subject: LU-7396 llite: check request != NULL in ll_migrate
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 702659da72603cee8184b3a796ab3276c0e5634a

[Joseph Gmitter (Inactive)]

Di,
could you please take a look at this issue for 2.8?
Thanks.
Joe