Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-7666

llog_cat_new_log() should use chunk size when freeing header

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.8.0
    • None
    • 3
    • 9223372036854775807

    Description

      In llog_cat_new_log() we create a spurious memory leak warning when we use OBD_FREE_PTR(loghandle->lgh_hdr) rather than OBD_FREE(..., loghandle->lgh_ctxt->loc_chunk_size).

      From leak_finder.pl:

      *** Free different size (32768 alloced, 8192 freed).
    malloc at llog.c:llog_init_handle:345, free at llog_cat.c:llog_cat_new_log:104

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-6602 ASSERTION( rec->lrh_len <= 8192 ) failed

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-6587 refactor OBD_ALLOC_LARGE to always do kmalloc first

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-7666] llog_cat_new_log() should use chunk size when freeing header
            jgmitter Joseph Gmitter (Inactive) made changes -
            Fix Version/s New: Lustre 2.8.0 [ 11113 ]
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            jgmitter Joseph Gmitter (Inactive) added a comment -

            Landed for 2.8.0

            jgmitter Joseph Gmitter (Inactive) added a comment - Landed for 2.8.0
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/18009/
            Subject: LU-7666 llog: use correct size when freeing log header
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 2b9ac5ce6399f1cec82a772c05aa64fec15b7112

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/18009/ Subject: LU-7666 llog: use correct size when freeing log header Project: fs/lustre-release Branch: master Current Patch Set: Commit: 2b9ac5ce6399f1cec82a772c05aa64fec15b7112
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-6587 [ LU-6587 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-6602 [ LU-6602 ]
            adilger Andreas Dilger added a comment -

            This problem was introduced in http://review.whamcloud.com/14883 "LU-6602 obdclass: variable llog chunk size".

            adilger Andreas Dilger added a comment - This problem was introduced in http://review.whamcloud.com/14883 " LU-6602 obdclass: variable llog chunk size".
            gerrit Gerrit Updater added a comment -

            John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/18009
            Subject: LU-7666 llog: use correct size when freeing log header
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: afe98c8874de48c4cc308fcef5ec369c1e871bb5

            gerrit Gerrit Updater added a comment - John L. Hammond (john.hammond@intel.com) uploaded a new patch: http://review.whamcloud.com/18009 Subject: LU-7666 llog: use correct size when freeing log header Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: afe98c8874de48c4cc308fcef5ec369c1e871bb5
            jgmitter Joseph Gmitter (Inactive) made changes -
            Assignee Original: WC Triage [ wc-triage ] New: John Hammond [ jhammond ]
            jgmitter Joseph Gmitter (Inactive) added a comment -

            Assigning to John as he is planning to push the patch.

            jgmitter Joseph Gmitter (Inactive) added a comment - Assigning to John as he is planning to push the patch.
            jhammond John Hammond created issue -

            People

              jhammond John Hammond
              jhammond John Hammond
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: