[LU-7877] Suspect locking cleanup in mdt_reint_rename_internal()

• Type: Bug
• Resolution: Not a Bug
• Priority: Minor
• Fix Version/s: Lustre 2.11.0
• Severity: 3
• Assignee: Lai Siyao
• Reporter: Oleg Drokin

Description

In mdt_reint_rename_internal():

                rc = mdt_reint_object_lock(info, mold, lh_oldp, lock_ibits,
                                           cos_incompat);
                if (rc != 0)
                        GOTO(out_unlock_old, rc);
...
                rc = mdt_reint_object_lock(info, mold, lh_oldp, lock_ibits,
                                           cos_incompat);
                if (rc != 0)
                        GOTO(out_unlock_old, rc);
...
out_unlock_old:
        mdt_object_unlock(info, mold, lh_oldp, rc);
out_put_new:
        if (mnew != NULL)
                mdt_object_put(info->mti_env, mnew);

I guess both of those GOTOs should go to out_put_new?