[LU-7939] ldiskfs_find_entry() returns ERR_PTR() but checked for NULL

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.9.0
• Labels: kw
• Severity: 3
• Assignee: Dmitry Eremin (Inactive)
• Reporter: Dmitry Eremin (Inactive)

Description

In lustre-release/ldiskfs/namei.c:

struct buffer_head *__ldiskfs_find_entry(struct inode *dir,
					const struct qstr *d_name,
					struct ldiskfs_dir_entry_2 **res_dir,
					int *inlined, struct htree_lock *lck)
{
[...]
bh = ldiskfs_getblk(NULL, dir, b++, 0, &err);
if (unlikely(err)) {
	if (ra_max == 0)
		return ERR_PTR(err);
[...]

old.bh = ldiskfs_find_entry(old.dir, &old.dentry->d_name,
				 &old.de, &old.inlined);
retval = -ENOENT;
if (!old.bh || le32_to_cpu(old.de->inode) != old.inode->i_ino)
	goto end_rename;

Issue Links

• duplicates: LU-8180 RHEL7 __ldiskfs_find_entry can now return ERR_PTR