Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-7943

Suspicious dereference of pointer before NULL check

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.12.0
    • Lustre 2.9.0
    • 3
    • 9223372036854775807

    Description

      Suspicious dereference of pointer 'sname' before NULL check at line 786

      • An event which alters the program's state, leading to the defect
        mdd_dir.c:782: 'sname' is dereferenced.
      • An event which alters the program's state, leading to the defect
        mdd_dir.c:786: 'sname' is checked for NULL.
      776		static void mdd_changelog_rec_ext_rename(struct changelog_rec *rec,
      777							 const struct lu_fid *sfid,
      778							 const struct lu_fid *spfid,
      779							 const struct lu_name *sname)
      780		{
      781			struct changelog_ext_rename	*rnm = changelog_rec_rename(rec);
      782			size_t				 extsize = sname->ln_namelen + 1;
      783		 
      784			LASSERT(sfid != NULL);
      785			LASSERT(spfid != NULL);
      786			LASSERT(sname != NULL);
      

      Attachments

        Activity

          [LU-7943] Suspicious dereference of pointer before NULL check
          pjones Peter Jones added a comment -

          Landed for 2.12

          pjones Peter Jones added a comment - Landed for 2.12

          Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/32376/
          Subject: LU-7943 mdd: Move assignment after LASSERT()
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: a5161cc005aeb383cb326a32976f8d43e7594bb3

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/32376/ Subject: LU-7943 mdd: Move assignment after LASSERT() Project: fs/lustre-release Branch: master Current Patch Set: Commit: a5161cc005aeb383cb326a32976f8d43e7594bb3

          Arshad Hussain (arshad.super@gmail.com) uploaded a new patch: https://review.whamcloud.com/32376
          Subject: LU-7943 mdd: Move assignment after LASSERT()
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 145e1b167e8d4609690d60d8e65c341022ca5b31

          gerrit Gerrit Updater added a comment - Arshad Hussain (arshad.super@gmail.com) uploaded a new patch: https://review.whamcloud.com/32376 Subject: LU-7943 mdd: Move assignment after LASSERT() Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 145e1b167e8d4609690d60d8e65c341022ca5b31

          People

            arshad512 Arshad Hussain
            dmiter Dmitry Eremin (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: