[LU-7949] Suspicious dereference of pointer before NULL check in osd_declare_qid()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Labels: kw
• Severity: 3
• Assignee: WC Triage
• Reporter: Dmitry Eremin (Inactive)

Description

Suspicious dereference of pointer 'oh' before NULL check at line 515

• An event which alters the program's state, leading to the defect
  osd_quota.c:508: 'oh' is dereferenced.
• An event which alters the program's state, leading to the defect
  osd_quota.c:515: 'oh' is checked for NULL.

504		int osd_declare_qid(const struct lu_env *env, struct osd_thandle *oh,
505				    struct lquota_id_info *qi, struct osd_object *obj,
506				    bool enforce, int *flags)
507		{
508			struct osd_device       *dev = osd_dt_dev(oh->ot_super.th_dev);
509			struct qsd_instance     *qsd = dev->od_quota_slave;
510			struct inode		*inode = NULL;
511			int                      i, rc = 0, crd;
512			bool                     found = false;
513			ENTRY;
514		 
515			LASSERT(oh != NULL);