[LU-7979] dereferencing ERR PTR in kiblnd_alloc_freg_pool

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Severity: 3
• Assignee: Dmitry Eremin (Inactive)
• Reporter: Oleg Drokin

Description

Recently landed FMR patch introduced this problem:

                frd->frd_frpl = ib_alloc_fast_reg_page_list(fpo->fpo_hdev->ibh_ibdev,
                                                            LNET_MAX_PAYLOAD/PAGE_SIZE);
                if (IS_ERR(frd->frd_frpl)) {
                        rc = PTR_ERR(frd->frd_frpl);
                        CERROR("Failed to allocate ib_fast_reg_page_list: %d\n",
                                rc);
                        goto out_middle;
                }

...
out_middle:
        if (frd->frd_mr)
                ib_dereg_mr(frd->frd_mr);
        if (frd->frd_frpl)
                ib_free_fast_reg_page_list(frd->frd_frpl);

We should be either assigning the frd_frpl NULL or expand the check at teh end, I guess.