[LU-8179] libcfs/util/ioctl.h unconditionally redefines __user

• Type: Bug
• Resolution: Fixed
• Priority: Major
• Fix Version/s: Lustre 2.9.0
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

__user attribute is used by sparse to determine what data could and could not be accessed. libcfs/util/ioctl.h is actually incuded by quite a bit of lustre kernel code, not just userspace, so we should make the redefinition conditional.

Comments

[Joseph Gmitter (Inactive)]

patch has landed to master for 2.9.0

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/20375/
Subject: LU-8179 libcfs: Do not include libcfs/util/ioctl.h in kernel code
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 0ecdb18ea46790a21f35f60d452e8fc7a50ce838

[James A Simmons]

libcfs/util/ioctl.h should never be used in kernel space. As you pointed out it is lustre_ioctl.h that is broken. I rather see lustre_ioctl.h fixed instead.

As a side topic __user should be handled more cleaning for user space. The reason for this work around is currently the uapi headers are not exposed to the lustre user land code. Plus if I do that we can remove byteorder.h from libcfs.

[Gerrit Updater]

Oleg Drokin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/20375
Subject: LU-8179 libcfs: Do not redefine __user for kernel code
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3e9b1098bd32126bb68824214a3891c78f6bbe35