[LU-8182] Suspicious code in mdt_obd_connect

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Severity: 3
• Assignee: nasf (Inactive)
• Reporter: Oleg Drokin

Description

In mdt_obd_connect() we dereference a "data" pointer and then check if it's not NULL which is strange.

        if ((data->ocd_connect_flags & OBD_CONNECT_MDS_MDS) &&
            !(data->ocd_connect_flags & OBD_CONNECT_LIGHTWEIGHT)) {
                atomic_inc(&mdt->mdt_mds_mds_conns);
                mdt_enable_slc(mdt);
        }

        if (!test_bit(MDT_FL_SYNCED, &mdt->mdt_state) && data != NULL &&

Issue Links

• is duplicated by: LU-7944 Suspicious dereference of pointer before NULL check in mdt_obd_connect()
• is related to: LU-8224 Possibly access of bad pointer in mdt_obd_connect()