[LU-8224] Possibly access of bad pointer in mdt_obd_connect()

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

In mdt_obd_connect we have:

        if ((data->ocd_connect_flags & OBD_CONNECT_MDS_MDS) &&
            !(data->ocd_connect_flags & OBD_CONNECT_LIGHTWEIGHT)) {
                atomic_inc(&mdt->mdt_mds_mds_conns);
                mdt_enable_slc(mdt);
        }
        if (!test_bit(MDT_FL_SYNCED, &mdt->mdt_state) && data != NULL &&

So it's either we should drop the data != NULL check or also check it above or do something els.e

Otherwise it just looks kind of bad and also confuses static code analyzers.

Issue Links

• is related to: LU-8182 Suspicious code in mdt_obd_connect

Comments

[Andreas Dilger]

Fixed in patch http://review.whamcloud.com/20391 "LU-8182 mdt: check connection data properly"

[Andreas Dilger]

This was filed in the wrong project.