[LU-8182] Suspicious code in mdt_obd_connect

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Severity: 3
• Assignee: nasf (Inactive)
• Reporter: Oleg Drokin

Description

In mdt_obd_connect() we dereference a "data" pointer and then check if it's not NULL which is strange.

        if ((data->ocd_connect_flags & OBD_CONNECT_MDS_MDS) &&
            !(data->ocd_connect_flags & OBD_CONNECT_LIGHTWEIGHT)) {
                atomic_inc(&mdt->mdt_mds_mds_conns);
                mdt_enable_slc(mdt);
        }

        if (!test_bit(MDT_FL_SYNCED, &mdt->mdt_state) && data != NULL &&

Issue Links

• is duplicated by: LU-7944 Suspicious dereference of pointer before NULL check in mdt_obd_connect()
• is related to: LU-8224 Possibly access of bad pointer in mdt_obd_connect()

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/20391/
Subject: LU-8182 mdt: check connection data properly
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 06072de19cf490f52b9f20dd5a8d9dc8509ceb3f

[Gerrit Updater]

Fan Yong ([e-mail]) uploaded a new patch: http://review.whamcloud.com/20391
Subject: LU-8182 mdt: check connection data properly
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 07829bb9f84612a398a2d26e47894c9e37bbb20d

[Joseph Gmitter (Inactive)]

Hi Fan Yong,

Can you please look at this code?

Thanks.
Joe