Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8182

Suspicious code in mdt_obd_connect

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.9.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      In mdt_obd_connect() we dereference a "data" pointer and then check if it's not NULL which is strange.

              if ((data->ocd_connect_flags & OBD_CONNECT_MDS_MDS) &&
            !(data->ocd_connect_flags & OBD_CONNECT_LIGHTWEIGHT)) {
                atomic_inc(&mdt->mdt_mds_mds_conns);
                mdt_enable_slc(mdt);
        }

        if (!test_bit(MDT_FL_SYNCED, &mdt->mdt_state) && data != NULL &&

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. LU-7944 Suspicious dereference of pointer before NULL check in mdt_obd_connect()

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-8224 Possibly access of bad pointer in mdt_obd_connect()

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-8182] Suspicious code in mdt_obd_connect
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-8224 [ LU-8224 ]
            pjones Peter Jones made changes -
            Link New: This issue is duplicated by LU-7944 [ LU-7944 ]
            yong.fan nasf (Inactive) made changes -
            Fix Version/s New: Lustre 2.9.0 [ 11891 ]
            Resolution New: Fixed [ 1 ]
            Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/20391/
            Subject: LU-8182 mdt: check connection data properly
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 06072de19cf490f52b9f20dd5a8d9dc8509ceb3f

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/20391/ Subject: LU-8182 mdt: check connection data properly Project: fs/lustre-release Branch: master Current Patch Set: Commit: 06072de19cf490f52b9f20dd5a8d9dc8509ceb3f
            gerrit Gerrit Updater added a comment -

            Fan Yong (fan.yong@intel.com) uploaded a new patch: http://review.whamcloud.com/20391
            Subject: LU-8182 mdt: check connection data properly
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 07829bb9f84612a398a2d26e47894c9e37bbb20d

            gerrit Gerrit Updater added a comment - Fan Yong (fan.yong@intel.com) uploaded a new patch: http://review.whamcloud.com/20391 Subject: LU-8182 mdt: check connection data properly Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 07829bb9f84612a398a2d26e47894c9e37bbb20d
            yong.fan nasf (Inactive) made changes -
            Status Original: Open [ 1 ] New: In Progress [ 3 ]
            jgmitter Joseph Gmitter (Inactive) made changes -
            Assignee Original: WC Triage [ wc-triage ] New: nasf [ yong.fan ]
            jgmitter Joseph Gmitter (Inactive) added a comment -

            Hi Fan Yong,

            Can you please look at this code?

            Thanks.
            Joe

            jgmitter Joseph Gmitter (Inactive) added a comment - Hi Fan Yong, Can you please look at this code? Thanks. Joe
            green Oleg Drokin created issue -

            People

              yong.fan nasf (Inactive)
              green Oleg Drokin
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: