[LU-8236] Wild-card in jobid TBF rule

• Type: Question/Request
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.10.0
• Affects Version/s: Lustre 2.7.0
• Assignee: Li Xi (Inactive)
• Reporter: Mahmoud Hanafi

Description

From the documentation it is not clear whether wild-card are suppose work in building tbf jobid rules. My test show it doesn't work.

For example

lctl set_param mds.MDS.mdt.nrs_tbf_rule="start rule1 { *.pbssrv1 } 100"
lctl set_param mds.MDS.mdt.nrs_tbf_rule="start rule2 { *.pbssrv2 } 500"

Issue Links

• is related to: LU-3558 NRS TBF policy for QoS purposes

Comments

[Wang Shilong (Inactive)]

Yingjin i think we'd better open another ticket, since this ticket has been closed for some time.

[Qian Yingjin (Inactive)]

One user reported that:
oss#lctl set_param ost.OSS.ost_io.nrs_policies="tbf jobid"
oss#lctl set_param ost.OSS.ost_io.nrs_tbf_rule="start runas jobid={*.500} rate=10"
oss# lctl get_param ost.OSS.ost_io.nrs_tbf_rule
ost.OSS.ost_io.nrs_tbf_rule=
regular_requests:
CPT 0:
runas {*.500} 10, ref 0
default {*} 10000, ref 2
high_priority_requests:
CPT 0:
runas {*.500} 10, ref 0
default {*} 10000, ref 1
------------------------------------------------------------------------------------------------------------
cli#lfs setstripe -c 1 -i 0 /mnt/lustre_2_10/qos/a1
cli#dd if=/dev/zero of=/mnt/lustre_2_10/qos/a1 count=1000 bs=1M
1000+0 records in
1000+0 records out
1048576000 bytes (1.0 GB) copied, 12.2554 s, 85.6 MB/s

The rate is not under control.

The patch above fixes the problem.

[Gerrit Updater]

Yingjin Qian ([e-mail]) uploaded a new patch: https://review.whamcloud.com/29162
Subject: LU-8236 nrs: mismatch problem for wildcard in jobid TBF
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 84fb7f45916851434ccecf7c9052790c8d3a48a1

[Peter Jones]

Landed for 2.10

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/24523/
Subject: LU-8236 nrs: Add wildcard support for JOBID TBF rule
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d5b5a07a8b07ab51a2215de593cb8bfce7e589d0

[Shuichi Ihara (Inactive)]

I would reopen this ticket since we have been working on it and submitted patch. https://review.whamcloud.com/#/c/24523

[Gerrit Updater]

Yingjin Qian ([e-mail]) uploaded a new patch: https://review.whamcloud.com/24523
Subject: LU-8236 nrs: Add wildcard support for JOBID TBF rule
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2723490a6f761710ffeb326ba030ae883068a91b

[Peter Jones]

ok Mahmoud

[Mahmoud Hanafi]

I think you can close this request.

[Peter Jones]

Li Xi

You are the author of this code. Could you plesae clarify?

Thanks

Peter