Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8260

osd_ldiskfs fiemap code wrong address space usage

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Lustre 2.13.0
    • None
    • 3
    • 9223372036854775807

    Description

      osd_io code seems to be using struct fiemap_extent's fi_extents_start field directly even though it has __user qualifier.
      We then pass this buffer straight into inode's fiemap method that does assume the pointer is userspace which is boind to break on some conigurations.

      We need to at least set ds to kernel_ds to have it working,
      or find some other wayst to call into fiemap code with kernelspace buffers.

      Offending functions are osd_fiemap_get() and osd_is_mapped()

      Attachments

        Activity

          [LU-8260] osd_ldiskfs fiemap code wrong address space usage
          pjones Peter Jones added a comment -

          Landed for 2.13

          pjones Peter Jones added a comment - Landed for 2.13

          Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33878/
          Subject: LU-8260 osd-ldiskfs: osd_fiemap_get() fix address space mismatch
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: dcafe7cb48f5e4582a4711652b38629c46675232

          gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/33878/ Subject: LU-8260 osd-ldiskfs: osd_fiemap_get() fix address space mismatch Project: fs/lustre-release Branch: master Current Patch Set: Commit: dcafe7cb48f5e4582a4711652b38629c46675232

          Arshad Hussain (arshad.super@gmail.com) uploaded a new patch: https://review.whamcloud.com/33878
          Subject: LU-8260 osd-ldiskfs: osd_fiemap_get() fix address space mismatch
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: ae220772026c20835bd79f01a419406f30042899

          gerrit Gerrit Updater added a comment - Arshad Hussain (arshad.super@gmail.com) uploaded a new patch: https://review.whamcloud.com/33878 Subject: LU-8260 osd-ldiskfs: osd_fiemap_get() fix address space mismatch Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: ae220772026c20835bd79f01a419406f30042899

          People

            arshad512 Arshad Hussain
            green Oleg Drokin
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: