[LU-832] sanity test 60a should be marked as failed if llog_test.ko cannot be loaded

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.11.0
• Severity: 3
• Assignee: Sarah Liu
• Reporter: Johann Lombardi (Inactive)

Description

I had a problem with symbol version mismatch which prevented some modules to be loaded and i noticed that sanity 60a is marked as PASS although the test was not run at all:

== sanity test 60a: llog sanity tests run from kernel module ============ 00:38:24 (1320914304)
test_60 run 18379 - from kernel mode
insmod: can't read '/usr/lib64/lustre/obdclass/llog_test.ko': No such file or directory
FATAL: Error inserting llog_test (/lib/modules/2.6.32-131.6.1.el6_lustre.gc31093a.x86_64/updates/kernel/fs/lustre/llog_test.ko): Unknown symbol in module, or unknown parameter (see dmesg)
Unable to load llog_test module!
Resetting fail_loc on all nodes...done.
PASS 60a (1s)

Comments

[Minh Diep]

Landed in 2.11

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/28412/
Subject: LU-832 test: Add error check when running run-llog.sh
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: e71fd5643766bed894d77951fa66b58d3b448563

[Gerrit Updater]

Wei Liu ([e-mail]) uploaded a new patch: https://review.whamcloud.com/28412
Subject: LU-832 test: Add error check when running run-llog.sh
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b7a63c578f5c842de9cddf540ce3e55976d7454e

[Peter Jones]

Sarah

Could you please advise on this one

Thanks

Peter

[Johann Lombardi (Inactive)]

diff --git a/lustre/tests/run-llog.sh b/lustre/tests/run-llog.sh
index 81c0e24..0df974e 100644
--- a/lustre/tests/run-llog.sh
+++ b/lustre/tests/run-llog.sh
@@ -21,7 +21,7 @@ TMP=${TMP:-/tmp}
 MGS=`lctl dl | awk '/mgs/ { print $4 }'`
 [ -z "$MGS" ] && echo "$0: SKIP: no MGS available, skipping llog test" && exit 0
 
-load_llog_test || exit 0
+load_llog_test || exit 1
 lctl modules > $TMP/ogdb-`hostname`
 echo "NOW reload debugging syms.."

Should be enough?