Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.9.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      The patch for LU-5614 introduced issue with absence of dependency from tests modules.
      Also Build dependency is specified incorrectly.

      Attachments

        Issue Links

          Activity

            [LU-8383] Wrong tests package dependencies

            Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: http://review.whamcloud.com/21229
            Subject: LU-8383 build: Spec file cleanup after LU-5614
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: a2ad8f2d2742f4661f3a52fb2662a5c20b18fb72

            gerrit Gerrit Updater added a comment - Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: http://review.whamcloud.com/21229 Subject: LU-8383 build: Spec file cleanup after LU-5614 Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: a2ad8f2d2742f4661f3a52fb2662a5c20b18fb72

            Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: http://review.whamcloud.com/21228
            Subject: LU-8383 build: Spec file cleanup after LU-5614
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: c36fbd320a0451f203879fa364cffb610db5c9c6

            gerrit Gerrit Updater added a comment - Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: http://review.whamcloud.com/21228 Subject: LU-8383 build: Spec file cleanup after LU-5614 Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: c36fbd320a0451f203879fa364cffb610db5c9c6

            OK, thats good.

            morrone Christopher Morrone (Inactive) added a comment - OK, thats good.

            Exactly, the string BuildRequires: %kernel_module_package_buildreqs will be transformed to BuildRequires: kernel-devel and additional macro will be defined.
            For now the string "kernel-devel" is appended to package description.
            With fixed dependencies build failed on SuSe with following:

            error: Failed build dependencies:
             kernel-syms is needed by lustre-2.8.55_49_g7174998-1.x86_64
            make: *** [srpm] Error 1
            

            So, dependency works now.

            dmiter Dmitry Eremin (Inactive) added a comment - Exactly, the string BuildRequires: %kernel_module_package_buildreqs will be transformed to BuildRequires: kernel-devel and additional macro will be defined. For now the string "kernel-devel" is appended to package description. With fixed dependencies build failed on SuSe with following: error: Failed build dependencies: kernel-syms is needed by lustre-2.8.55_49_g7174998-1.x86_64 make: *** [srpm] Error 1 So, dependency works now.

            It looks like you want to move the call to %kernel_module_package_buildreqs. But I'm not sure that is correct. Although, admittedly, I don't really understand what they were thinking when they made kernel_module_package_buildreqs.

            If you use rpmbuild --showrc to look at the definition of kernel_module_package_buildreqs on a RHEL7.2 system, it looks like this:

            -14: kernel_module_package_buildreqs    %global kmodtool_generate_buildreqs 1 
                                                    kernel-devel
            

            So what exactly happens when you try to move the call to that macro to be the following?

            BuildRequires: %kernel_module_package_buildreqs
            

            If you try to define a macro on a BuildRequires line, does that even work? Will the "kernel-devel" string, which is on a separate line in the kernel_module_package_buildreqs macro even wind up being added to the BuildRequires?

            Maybe it is fine. I wish the spec file syntax was more rigorously defined somewhere.

            morrone Christopher Morrone (Inactive) added a comment - It looks like you want to move the call to %kernel_module_package_buildreqs. But I'm not sure that is correct. Although, admittedly, I don't really understand what they were thinking when they made kernel_module_package_buildreqs. If you use rpmbuild --showrc to look at the definition of kernel_module_package_buildreqs on a RHEL7.2 system, it looks like this: -14: kernel_module_package_buildreqs %global kmodtool_generate_buildreqs 1 kernel-devel So what exactly happens when you try to move the call to that macro to be the following? BuildRequires: %kernel_module_package_buildreqs If you try to define a macro on a BuildRequires line, does that even work? Will the "kernel-devel" string, which is on a separate line in the kernel_module_package_buildreqs macro even wind up being added to the BuildRequires? Maybe it is fine. I wish the spec file syntax was more rigorously defined somewhere.

            Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: http://review.whamcloud.com/21208
            Subject: LU-8383 build: Spec file cleanup after LU-5614
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: ba973ec97df69912d29c4c12022af4688261d0ca

            gerrit Gerrit Updater added a comment - Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: http://review.whamcloud.com/21208 Subject: LU-8383 build: Spec file cleanup after LU-5614 Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: ba973ec97df69912d29c4c12022af4688261d0ca

            People

              dmiter Dmitry Eremin (Inactive)
              dmiter Dmitry Eremin (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: