[LU-8383] Wrong tests package dependencies

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Severity: 3
• Assignee: Dmitry Eremin (Inactive)
• Reporter: Dmitry Eremin (Inactive)

Description

The patch for LU-5614 introduced issue with absence of dependency from tests modules.
Also Build dependency is specified incorrectly.

Issue Links

• is related to: LU-5614 use %kernel_module_package for weak-updates

Comments

[Gerrit Updater]

Oleg Drokin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/21877
Subject: Revert "LU-8383 build: Spec file cleanup after LU-5614"
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ae9e55067c5830066dc10844ad62b63d3ee0125a

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/21208/
Subject: LU-8383 build: Spec file cleanup after LU-5614
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 55836cd0e55eb1912911c6f195412c99852115aa

[Dmitry Eremin (Inactive)]

I installed kernel-syms on all the SLES builders and build is fixed now.

[Christopher Morrone (Inactive)]

Have Minh install kernel-syms on all the SLES builders?

[Dmitry Eremin (Inactive)]

For SuSe we have BuildRequires: module-init-tools kernel-syms. But the package kernel-syms is just an empty package.
It is used to group build dependencies for all kernel flavors. The KMP build process will build KMPs against all installed kernel flavors automatically.

So, it's not clear how to build lustre packages without this package installed. For now lbuild for SuSe failed with following:

error: Failed build dependencies:
 kernel-syms is needed by lustre-2.8.55_49_g7174998-1.x86_64

[Gerrit Updater]

Dmitry Eremin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/21229
Subject: LU-8383 build: Spec file cleanup after LU-5614
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a2ad8f2d2742f4661f3a52fb2662a5c20b18fb72

[Gerrit Updater]

Dmitry Eremin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/21228
Subject: LU-8383 build: Spec file cleanup after LU-5614
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c36fbd320a0451f203879fa364cffb610db5c9c6

[Christopher Morrone (Inactive)]

OK, thats good.

[Dmitry Eremin (Inactive)]

Exactly, the string BuildRequires: %kernel_module_package_buildreqs will be transformed to BuildRequires: kernel-devel and additional macro will be defined.
For now the string "kernel-devel" is appended to package description.
With fixed dependencies build failed on SuSe with following:

error: Failed build dependencies:
 kernel-syms is needed by lustre-2.8.55_49_g7174998-1.x86_64
make: *** [srpm] Error 1

So, dependency works now.

[Christopher Morrone (Inactive)]

It looks like you want to move the call to %kernel_module_package_buildreqs. But I'm not sure that is correct. Although, admittedly, I don't really understand what they were thinking when they made kernel_module_package_buildreqs.

If you use rpmbuild --showrc to look at the definition of kernel_module_package_buildreqs on a RHEL7.2 system, it looks like this:

-14: kernel_module_package_buildreqs    %global kmodtool_generate_buildreqs 1 
                                        kernel-devel

So what exactly happens when you try to move the call to that macro to be the following?

BuildRequires: %kernel_module_package_buildreqs

If you try to define a macro on a BuildRequires line, does that even work? Will the "kernel-devel" string, which is on a separate line in the kernel_module_package_buildreqs macro even wind up being added to the BuildRequires?

Maybe it is fine. I wish the spec file syntax was more rigorously defined somewhere.

[Gerrit Updater]

Dmitry Eremin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/21208
Subject: LU-8383 build: Spec file cleanup after LU-5614
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ba973ec97df69912d29c4c12022af4688261d0ca