[LU-8400] Remove OBD_IOC_GET_MNTOPT ioctl as it's only used to pass info between mdd and mdt

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.11.0
• Labels: easy
• Severity: 3
• Assignee: Henri Doreau (Inactive)
• Reporter: Nathaniel Clark

Description

The OBD_IOC_GET_MNTOPT ioctl should be removed because it's not actually usable in user-space and is only used by kernel in mdd and mdt to pass information.

Issue Links

• is related to: LU-8330 Incorrect ioctl definitions declaring a pointer to buffer instead of buffer argument.

Comments

[Peter Jones]

Landed for 2.11

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/28777/
Subject: LU-8400 mdd: remove OBD_IOC_GET_MNTOPT
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 20ffe2191c828d3e4922429f2a98584d4e41eb53

[Gerrit Updater]

Henri Doreau ([e-mail]) uploaded a new patch: https://review.whamcloud.com/28777
Subject: LU-8400 mdd: remove OBD_IOC_GET_MNTOPT
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 5f60a895cc976f8df9cdd7dc7883eb5b4bb60511

[Henri Doreau (Inactive)]

BTW I realized that another ioctl had opcode 220... good time to remove it.

[Andreas Dilger]

It appears that both OBD_IOC_GET_MNTOPT and mdd_maxeasize_get() should either be replaced by a single mdd_dtconf_get() method that returns struct dt_device_param to the caller, or GET_MNTOPT should be replaced by a new mdd_mntopt_get() method for consistency. In either case the OBD_IOC_GET_MNTOPT definition should be removed, though a stub should be left behind, like:

 /*   was   OBD_IOC_GET_MNTOPT      _IOW ('f', 220, mntopt_t) until 2.9 */