Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8492

ptlrpc: Correctly calculate hrp->hrp_nthrs

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.9.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      This ticket separates out patch http://review.whamcloud.com/#/c/19106/ from LU-6285 was already resolved when the new issue was identified (as noted in LU-6285)

      It addresses the following:

      There is still an issue which could cause the assert.

      cpu_pattern can sepcify exactly 1 cpu in a partition:
      "0[0]". That means CPT0 will have CPU 0. CPU 0 can have
      hyperthreading enabled. This combination would result in

      weight = cfs_cpu_ht_nsiblings(0);
      hrp->hrp_nthrs = cfs_cpt_weight(ptlrpc_hr.hr_cpt_table, i);
      hrp->hrp_nthrs /= weight;
      

      evaluating to 0. Where

      cfs_cpt_weight(ptlrpc_hr.hr_cpt_table, i) == 1
      weight == 2
      

      Therefore only divide out with weight if

      hrp->hrp_nthrs >= weight
      

      This will avoid the assert:

      LASSERT(hrp->hrp_nthrs > 0);
      

      Attachments

        Issue Links

          Activity

            [LU-8492] ptlrpc: Correctly calculate hrp->hrp_nthrs
            pjones Peter Jones added a comment -

            Landed for 2.9

            pjones Peter Jones added a comment - Landed for 2.9

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/19106/
            Subject: LU-8492 ptlrpc: Correctly calculate hrp->hrp_nthrs
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 402825050f95fff80a021e6eb04aa49a210648c9

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/19106/ Subject: LU-8492 ptlrpc: Correctly calculate hrp->hrp_nthrs Project: fs/lustre-release Branch: master Current Patch Set: Commit: 402825050f95fff80a021e6eb04aa49a210648c9
            dmiter Dmitry Eremin (Inactive) added a comment - My patch http://review.whamcloud.com/23222 contain this http://review.whamcloud.com/19106 patch.

            Dmitry: does your new patch replace http://review.whamcloud.com/#/c/19106/?

            doug Doug Oucharek (Inactive) added a comment - Dmitry: does your new patch replace http://review.whamcloud.com/#/c/19106/?
            gerrit Gerrit Updater added a comment - - edited

            remove incorrect comment

            gerrit Gerrit Updater added a comment - - edited remove incorrect comment
            jgmitter Joseph Gmitter (Inactive) added a comment - Patch is http://review.whamcloud.com/#/c/19106/

            People

              ashehata Amir Shehata (Inactive)
              jgmitter Joseph Gmitter (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: