Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8530

Bad configure code snuck into ldiskfs LDISKFS_LINUX_SERIES macro

    Details

    • Type: Bug
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None
    • Severity:
      3
    • Rank (Obsolete):
      9223372036854775807

      Description

      This bad code was snuck into a "kernel update" patch, in commit 6c9384678f5555f87bcc7311bb5bf73b1e4bf4e4.

      case x$LDISKFS_SERIES in
      	x)			# not set
      		;;
      	*.series)		# set externally
      		;;
      	*) LDISKFS_SERIES=
      esac
      AS_IF([test -z "$LDISKFS_SERIES"], [
      

      Not even a comment in the commit message to explain it's existence, so I'm left to guess at what the author intended. But whatever was intended, this isn't the right way to go about it.

      I'll submit a patch to revert this section.

        Attachments

          Activity

            People

            • Assignee:
              ys Yang Sheng
              Reporter:
              morrone Christopher Morrone
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated: