Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8629

Error exit path doing wrong cleanup in cl_env_percpu_init

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.9.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      Upstream kernel guys found a bug in cl_env_percpu_init:

              if (rc != 0) {
                      /* Indices 0 to i (excluding i) were correctly initialized,
                       * thus we must uninitialize up to i, the rest are undefined. */
                      for (j = 0; j < i; j++) {
                              cle = &cl_env_percpu[i];
                              lu_context_exit(&cle->ce_ses);
                              lu_context_fini(&cle->ce_ses);
                              lu_env_fini(&cle->ce_lu);
                      }
              }
      

      Here clearly cle = &cl_env_percpu[i] should be cle = &cl_env_percpu[j];

      Attachments

        Issue Links

          Activity

            People

              wc-triage WC Triage
              green Oleg Drokin
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: