[LU-8629] Error exit path doing wrong cleanup in cl_env_percpu_init

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Severity: 3
• Assignee: WC Triage
• Reporter: Oleg Drokin

Description

Upstream kernel guys found a bug in cl_env_percpu_init:

        if (rc != 0) {
                /* Indices 0 to i (excluding i) were correctly initialized,
                 * thus we must uninitialize up to i, the rest are undefined. */
                for (j = 0; j < i; j++) {
                        cle = &cl_env_percpu[i];
                        lu_context_exit(&cle->ce_ses);
                        lu_context_fini(&cle->ce_ses);
                        lu_env_fini(&cle->ce_lu);
                }
        }

Here clearly cle = &cl_env_percpu[i] should be cle = &cl_env_percpu[j];

Issue Links

• is related to: LU-4423 Tracking of patches from upstream kernel to Lustre client

Comments

[Peter Jones]

Landed for 2.9

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch http://review.whamcloud.com/22635/
Subject: LU-8629 obdclass: Fix error exit loop in cl_env_percpu_init
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: cf5882e6d381c18ec07d53a38010fcf2eb0d754d

[James A Simmons]

Thanks Oleg for porting this fix.

[Gerrit Updater]

Oleg Drokin ([e-mail]) uploaded a new patch: http://review.whamcloud.com/22635
Subject: LU-8629 Fix error exit loop in cl_env_percpu_init
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 7e28f55d06c565624ddb90d4cc569c206a6c9feb