Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8645

Update imp_known_replied_xid for resend-replay

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Lustre 2.9.0
    • Lustre 2.8.0, Lustre 2.9.0
    • None
    • 3
    • 9223372036854775807

    Description

      The imp_known_replied_xid is updated each time when we try to get the known replied xid by following function:

      __u64 ptlrpc_known_replied_xid(struct obd_import *imp)
      {
              struct ptlrpc_request *req;
      
              assert_spin_locked(&imp->imp_lock);
              if (list_empty(&imp->imp_unreplied_list))
                      return 0;
      
              req = list_entry(imp->imp_unreplied_list.next, struct ptlrpc_request,
                               rq_unreplied_list);
              LASSERTF(req->rq_xid >= 1, "XID:%llu\n", req->rq_xid);
      
              if (imp->imp_known_replied_xid < req->rq_xid - 1)
                      imp->imp_known_replied_xid = req->rq_xid - 1;
      
              return req->rq_xid - 1;
      }
      

      Usually, the imp_known_replied_xid should be less than or equal to the miminal xid in unreplied list, one exception is resend-repaly request, on reconnection during recovery, we may resend an already replied replay request by re-adding it to unreplied list. The above function needs be amended to handle this case.

      Attachments

        Activity

          [LU-8645] Update imp_known_replied_xid for resend-replay
          mdiep Minh Diep made changes -
          Link New: This issue is related to LDEV-341 [ LDEV-341 ]
          mdiep Minh Diep made changes -
          Link New: This issue is related to LDEV-367 [ LDEV-367 ]
          mdiep Minh Diep made changes -
          Link New: This issue is related to JFC-17 [ JFC-17 ]
          jgmitter Joseph Gmitter (Inactive) made changes -
          Link New: This issue is related to CTCH-23 [ CTCH-23 ]
          pjones Peter Jones made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          adilger Andreas Dilger made changes -
          Affects Version/s New: Lustre 2.8.0 [ 11113 ]
          Affects Version/s New: Lustre 2.9.0 [ 11891 ]
          adilger Andreas Dilger made changes -
          Fix Version/s New: Lustre 2.9.0 [ 11891 ]
          adilger Andreas Dilger made changes -
          Priority Original: Minor [ 4 ] New: Major [ 3 ]
          niu Niu Yawei (Inactive) made changes -
          Link New: This issue is related to LDEV-477 [ LDEV-477 ]
          niu Niu Yawei (Inactive) created issue -

          People

            niu Niu Yawei (Inactive)
            niu Niu Yawei (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: