Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-9033

Don't zero timestamps in lock blocking callback

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.10.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      In ll_md_blocking_ast(), we zero all timestamps to avoid these 'leftovers' interfering the new timestamps from MDS, especially when the timestamps are set back by other clients. It's not quite right to change timestamps in this way, because:

      1. The pending lock can be matched by getattr, so these zero timestamps can be fetched by application in a small race window.

      2. It doesn't make sense to zero the mtime and ctime, because we always use the newest ctime and mtime from MDS when do attributes merge, the 'leftovers' won't interfere new timestamps set by other clients.

      Attachments

        Activity

          [LU-9033] Don't zero timestamps in lock blocking callback
          pjones Peter Jones added a comment -

          Landed for 2.10

          pjones Peter Jones added a comment - Landed for 2.10

          Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/24984/
          Subject: LU-9033 llite: don't zero timestamps internally
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 8718346e06cf2e17447dd3e3dc4e45b66d945aaf

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/24984/ Subject: LU-9033 llite: don't zero timestamps internally Project: fs/lustre-release Branch: master Current Patch Set: Commit: 8718346e06cf2e17447dd3e3dc4e45b66d945aaf

          Niu Yawei (yawei.niu@intel.com) uploaded a new patch: https://review.whamcloud.com/24984
          Subject: LU-9033 llite: don't zero timestamps internally
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 05a3ee7523d7bcdf7e1897669c4df2c9160c11ca

          gerrit Gerrit Updater added a comment - Niu Yawei (yawei.niu@intel.com) uploaded a new patch: https://review.whamcloud.com/24984 Subject: LU-9033 llite: don't zero timestamps internally Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 05a3ee7523d7bcdf7e1897669c4df2c9160c11ca

          People

            niu Niu Yawei (Inactive)
            niu Niu Yawei (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: