Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-9155

number of args changed in posix_acl_valid

    XMLWordPrintable

Details

    • Bug
    • Resolution: Duplicate
    • Minor
    • None
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      The kernel API posix_acl_valid called by us in mdc_request.c was changed in upstream linux by the following commit:

      commit 0d4d717f25834134bb6f43284f84c8ccee5bbf2a
      Author: Eric W. Biederman <ebiederm@xmission.com>
      Date:   Mon Jun 27 16:04:06 2016 -0500
      
          vfs: Verify acls are valid within superblock's s_user_ns.
          
          Update posix_acl_valid to verify that an acl is within a user namespace.
          
          Update the callers of posix_acl_valid to pass in an appropriate
          user namespace.  For posix_acl_xattr_set and v9fs_xattr_set_acl pass in
          inode->i_sb->s_user_ns to posix_acl_valid.  For md_unpack_acl pass in
          &init_user_ns as no inode or superblock is in sight.
          
          Acked-by: Seth Forshee <seth.forshee@canonical.com>
          Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
      

      Among other things this adds a namespace argument to posix_acl_valid().

      We need to add autoconf support to be able to build with either the old or new version of this kernel API.

      Attachments

        Issue Links

          Activity

            People

              bogl Bob Glossman (Inactive)
              bogl Bob Glossman (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: