[LU-9155] number of args changed in posix_acl_valid

• Type: Bug
• Resolution: Duplicate
• Priority: Minor
• Severity: 3
• Assignee: Bob Glossman (Inactive)
• Reporter: Bob Glossman (Inactive)

Description

The kernel API posix_acl_valid called by us in mdc_request.c was changed in upstream linux by the following commit:

commit 0d4d717f25834134bb6f43284f84c8ccee5bbf2a
Author: Eric W. Biederman <[e-mail]>
Date:   Mon Jun 27 16:04:06 2016 -0500

    vfs: Verify acls are valid within superblock's s_user_ns.
    
    Update posix_acl_valid to verify that an acl is within a user namespace.
    
    Update the callers of posix_acl_valid to pass in an appropriate
    user namespace.  For posix_acl_xattr_set and v9fs_xattr_set_acl pass in
    inode->i_sb->s_user_ns to posix_acl_valid.  For md_unpack_acl pass in
    &init_user_ns as no inode or superblock is in sight.
    
    Acked-by: Seth Forshee <[e-mail]>
    Signed-off-by: "Eric W. Biederman" <[e-mail]>

Among other things this adds a namespace argument to posix_acl_valid().

We need to add autoconf support to be able to build with either the old or new version of this kernel API.

Issue Links

• duplicates: LU-9003 Linux kernel 4.8 adds user_namespace arg to posix_acl_valid

Comments

[James A Simmons]

BTW your patch is on the right track. The other patch for LU-9003 was rejected.

[Bob Glossman (Inactive)]

James,
I see that this is a dup as you say. I wasn't aware of LU-9003.
I will close this ticket as a dup.

Thanks for pointing it out.

[James A Simmons]

This is a duplicate of LU-9003

[Gerrit Updater]

Bob Glossman ([e-mail]) uploaded a new patch: https://review.whamcloud.com/25619
Subject: LU-9155 mdc: number of args changed in posix_acl_valid
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d140db8cf5d4598688980b4fedfc5c1f6c2fdced