[LU-9245] lgss_sk may unsafely overwrite nodemap and fsname fields in keys

• Type: Bug
• Resolution: Fixed
• Priority: Trivial
• Fix Version/s: Lustre 2.10.0
• Affects Version/s: Lustre 2.9.0
• Severity: 4
• Assignee: Chris Hanna (Inactive)
• Reporter: Chris Hanna (Inactive)

Description

lgss_sk.c uses strncpy() to modify names of strings for both fsname and nodemap fields. If the replacement string is smaller than the original string, it will not be zero terminated properly. For example, replacing a nodemap name of "default" with "c0" with the lgss_sk utility can result in invalid names such as:

Nodemap name: c0fault

I will submit a small patch to switch this to snprintf(), although being a little more verbose, will be safe to use on a parameter of variable length.

Issue Links

• is related to: LU-8602 Support GSS crypto code with linux 4.6 kernels